Skip to content

fix(stories): adjust search scroll behavior#112045

Merged
natemoo-re merged 5 commits intomasterfrom
stories/search-scroll
Apr 8, 2026
Merged

fix(stories): adjust search scroll behavior#112045
natemoo-re merged 5 commits intomasterfrom
stories/search-scroll

Conversation

@natemoo-re
Copy link
Copy Markdown
Member

@natemoo-re natemoo-re commented Apr 1, 2026

removes hardcoded position overrides in story search and removes virtualization

fixes DE-1042, DE-1022

See Preview Deployment

@linear-code
Copy link
Copy Markdown

linear-code bot commented Apr 1, 2026

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 1, 2026
@natemoo-re natemoo-re marked this pull request as ready for review April 2, 2026 16:18
@natemoo-re natemoo-re requested a review from a team as a code owner April 2, 2026 16:18
@JonasBa
Copy link
Copy Markdown
Member

JonasBa commented Apr 2, 2026

@natemoo-re I found the perf in dev mode to be quite poor if we don't virtualize the list, did that improve through some other change, or what allows us to drop the virtualization?

@TkDodo
Copy link
Copy Markdown
Collaborator

TkDodo commented Apr 3, 2026

Ideally we’d keep virtualization but drop the second scrollbar :)

@natemoo-re natemoo-re enabled auto-merge (squash) April 8, 2026 14:10
@natemoo-re natemoo-re merged commit 2866576 into master Apr 8, 2026
64 checks passed
@natemoo-re natemoo-re deleted the stories/search-scroll branch April 8, 2026 14:17
george-sentry pushed a commit that referenced this pull request Apr 9, 2026
removes hardcoded position overrides in story search and removes
virtualization

fixes DE-1042, DE-1022

See [Preview
Deployment](https://sentry-git-stories-search-scroll.sentry.dev/stories)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants